lisirrx commented on PR #9161: URL: https://github.com/apache/iceberg/pull/9161#issuecomment-1829805915
I wonder if this workaround is good enough. I'm working on #9073 which also encountered the same question. And there are too many different tests depend on a base [`TableTestBase`](https://github.com/apache/iceberg/blob/main/core/src/test/java/org/apache/iceberg/TableTestBase.java) which has a constructor with a param that used for class level parameterizing. Many of these test classes also have their own class level parameterizing. 😂 It is very hard to extend these tests by dividing to 2 version Maybe we need to discuss a plan to deal with this situation. @nastra Could you like to help us by providing some suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
