nastra commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1404010724
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/SparkTestHelperBase.java:
##########
@@ -69,19 +72,25 @@ protected void assertEquals(
}
protected void assertEquals(String context, Object[] expectedRow, Object[]
actualRow) {
- Assert.assertEquals("Number of columns should match", expectedRow.length,
actualRow.length);
+ Assertions.assertThat(actualRow.length)
+ .as("Number of columns should match")
+ .isEqualTo(expectedRow.length);
for (int col = 0; col < actualRow.length; col += 1) {
Object expectedValue = expectedRow[col];
Object actualValue = actualRow[col];
if (expectedValue != null && expectedValue.getClass().isArray()) {
String newContext = String.format("%s (nested col %d)", context, col +
1);
if (expectedValue instanceof byte[]) {
- Assert.assertArrayEquals(newContext, (byte[]) expectedValue,
(byte[]) actualValue);
+ Assertions.assertThat((byte[]) actualValue)
+ .as(newContext)
+ .isEqualTo((byte[]) expectedValue);
Review Comment:
this cast shouldn't be required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
