tomtongue commented on PR #9129: URL: https://github.com/apache/iceberg/pull/9129#issuecomment-1824673027
Thanks for the review, @nastra! I add the following changes based on the reviews: * Change `SparkTestHelperBase` with the AssertJ style (removed `TestHelperBase`) * Switch `TestSparkFileRewriter`'s super class to `TestBase` (from `SparkTestBase`) * Change `TestSparkFileRewriter` with the AssertJ style * Remove `temp` from `CatalogTestBase` and change `temp` scope in its super class to `protected` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
