nastra commented on code in PR #9090:
URL: https://github.com/apache/iceberg/pull/9090#discussion_r1397540875


##########
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java:
##########
@@ -130,7 +130,7 @@ public void initialize(String name, Map<String, String> 
properties) {
   void initialize(
       String name, String path, AwsProperties properties, DynamoDbClient 
client, FileIO io) {
     Preconditions.checkArgument(
-        path != null && path.length() > 0,
+        path != null && !path.isEmpty(),

Review Comment:
   we recently removed all commons lang3 usages across the codebase (except for 
in Spark, since it has a transitive dependency on it), thus I'd suggest to go 
with `Strings` from the `iceberg-guava` module



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to