ndrluis commented on code in PR #9090:
URL: https://github.com/apache/iceberg/pull/9090#discussion_r1397473471
##########
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java:
##########
@@ -130,7 +130,7 @@ public void initialize(String name, Map<String, String>
properties) {
void initialize(
String name, String path, AwsProperties properties, DynamoDbClient
client, FileIO io) {
Preconditions.checkArgument(
- path != null && path.length() > 0,
+ path != null && !path.isEmpty(),
Review Comment:
@RussellSpitzer, thank you for the suggestion!
Currently, in Checkstyle the use of `StringUtils` import through
`org.apache.commons.lang` is prohibited, and it is indicated to import via
`org.apache.commons.lang3`. However, it is only available in the Spark module.
[Link to Checkstyle
rule](https://github.com/apache/iceberg/blob/main/.baseline/checkstyle/checkstyle.xml#L206-L209)
Which import should I use in the Core module?
In the Dell module, we don't have any `StringUtils` option that contains the
`.isNotBlank()` method. What library can I add?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
