nastra commented on code in PR #8976:
URL: https://github.com/apache/iceberg/pull/8976#discussion_r1385056741
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Properties.java:
##########
@@ -27,6 +27,9 @@ private OAuth2Properties() {}
/** A credential to exchange for a token in the OAuth2 client credentials
flow. */
public static final String CREDENTIAL = "credential";
+ /** Token endpoint URI to fetch token from if the Rest Catalog is not the
authorization server. */
+ public static final String TOKEN_URI = "token-uri";
Review Comment:
I think naming this `TOKEN_URI` is confusing because the credential is also
fetched from this endpoint. Maybe rename this to `OAUTH2_SERVER_URI`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
