pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1395338328
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/reader/IcebergWatermarkExtractor.java:
##########
@@ -18,19 +18,11 @@
*/
package org.apache.iceberg.flink.source.reader;
-import org.apache.flink.api.connector.source.SourceOutput;
-import org.apache.flink.connector.base.source.reader.RecordEmitter;
+import java.io.Serializable;
import org.apache.iceberg.flink.source.split.IcebergSourceSplit;
-final class IcebergSourceRecordEmitter<T>
- implements RecordEmitter<RecordAndPosition<T>, T, IcebergSourceSplit> {
-
- IcebergSourceRecordEmitter() {}
-
- @Override
- public void emitRecord(
- RecordAndPosition<T> element, SourceOutput<T> output, IcebergSourceSplit
split) {
- output.collect(element.record());
- split.updatePosition(element.fileOffset(), element.recordOffset());
- }
+/** The interface used to extract watermarks from splits. */
+public interface IcebergWatermarkExtractor extends Serializable {
+ /** Get the watermark for a split. */
Review Comment:
This is not defined by the interface. Further implementations might differ,
so I would not put this here.
`TimestampBasedWatermarkExtractor` comments contains this:
```
* {@link SplitWatermarkExtractor} implementation which uses an Iceberg
timestamp column
* statistics to get the watermarks for the {@link IcebergSourceSplit}.
```
I am not sure we want to document further implementation details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
