pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1394117352
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##########
@@ -429,6 +440,20 @@ public Builder<T> setAll(Map<String, String> properties) {
return this;
}
+ /**
+ * Sets the {@link IcebergWatermarkExtractor} to retrieve the split
watermark before emitting
+ * the records for a given split. The {@link
+ * IcebergWatermarkExtractor#extractWatermark(IcebergSourceSplit)} is also
used for ordering the
+ * splits for read.
+ */
+ public Builder<T> watermarkExtractor(IcebergWatermarkExtractor<T>
newWatermarkExtractor) {
Review Comment:
Gone for:
```
IcebergSource.<RowData>builder()
.tableLoader(sourceTableResource.tableLoader())
.watermarkColumn("ts")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
