pvary commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1389225623
##########
core/src/main/java/org/apache/iceberg/BaseScan.java:
##########
@@ -165,6 +170,19 @@ public ThisT includeColumnStats() {
return newRefinedScan(table, schema,
context.shouldReturnColumnStats(true));
}
+ @Override
+ public ThisT includeColumnStats(Collection<String> requestedColumns) {
+ return newRefinedScan(
+ table,
+ schema,
+ context
+ .shouldReturnColumnStats(true)
Review Comment:
Let's talk about this.
My main arguments will be:
- Backward compatibility - no need to change the API
- No hidden meaning for specific list values (null, empty)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
