pvary commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1389171088
##########
api/src/main/java/org/apache/iceberg/Scan.java:
##########
@@ -77,6 +77,21 @@ public interface Scan<ThisT, T extends ScanTask, G extends
ScanTaskGroup<T>> {
*/
ThisT includeColumnStats();
+ /**
+ * Create a new scan from this that loads the column stats for the specific
columns with each data
+ * file.
+ *
+ * <p>Column stats include: value count, null value count, lower bounds, and
upper bounds.
+ *
+ * @param requestedColumns column names for which to keep the stats. If
<code>null</code> then all
Review Comment:
I would guess that the situation is the similar with the other `@Nullable`
`TableScanContext` attributes, like:
- snapshotId
- selectedColumns
- projectedSchema
- fromSnapshotId
- toSnapshotId
- branch
We have an undefined default behaviour which could be archived with not
setting the values, or setting them to `null`. The only difference here is that
we define this default behaviour. For consistency's sake we can remove the
comment, but the behaviour will remain the same.
Do I miss something?
Thanks for the detailed review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
