HonahX commented on issue #22:
URL: https://github.com/apache/iceberg-python/issues/22#issuecomment-1797949558
@Fokko Thanks for the explanation!
> Ability to write the JSON to the object store (that was the intent of this
PR).
I think we already support
this:https://github.com/apache/iceberg-python/blob/8e8d39dacde067773d6d840b9bf65070399957a9/pyiceberg/catalog/__init__.py#L571-L572
Could you please elaborate on this a bit? Are there additional features we
are looking to implement beyond the `_write_metadata` method?
> Have logic to update the metadata dictionary as you pointed out above. I
think we can do this per operation (update schema, update partition-spec,
update sort-order, etc) to keep it small and we can get it in quickly.
I plan to start with `update_schema`, `set_snapshot_ref`, and
`add_snapshot`, given that update_schema is already supported and the other two
operations are pivotal for write support.
I will try to make a draft PR soon for further discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
