nastra commented on code in PR #8988:
URL: https://github.com/apache/iceberg/pull/8988#discussion_r1383168479
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java:
##########
@@ -199,7 +201,7 @@ public <T> Boolean lt(BoundReference<T> ref, Literal<T>
lit) {
int id = ref.fieldId();
Boolean hasNonDictPage = isFallback.get(id);
- if (hasNonDictPage == null || hasNonDictPage) {
+ if (hasNonDictPage == null || hasNonDictPage || isInt96Column(id)) {
Review Comment:
I would have expected something like this:
```
---
a/parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java
+++
b/parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java
@@ -19,6 +19,7 @@
package org.apache.iceberg.parquet;
import java.io.IOException;
+import java.nio.ByteOrder;
import java.util.Comparator;
import java.util.Map;
import java.util.Set;
@@ -447,6 +448,13 @@ public class ParquetDictionaryRowGroupFilter {
case INT64:
dictSet.add((T) conversion.apply(dict.decodeToLong(i)));
break;
+ case INT96:
+ dictSet.add(
+ (T)
+ conversion.apply(
+ ParquetUtil.extractTimestampInt96(
+
dict.decodeToBinary(i).toByteBuffer().order(ByteOrder.LITTLE_ENDIAN))));
+ break;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
