nastra commented on code in PR #8988:
URL: https://github.com/apache/iceberg/pull/8988#discussion_r1383166362
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java:
##########
@@ -199,7 +201,7 @@ public <T> Boolean lt(BoundReference<T> ref, Literal<T>
lit) {
int id = ref.fieldId();
Boolean hasNonDictPage = isFallback.get(id);
- if (hasNonDictPage == null || hasNonDictPage) {
+ if (hasNonDictPage == null || hasNonDictPage || isInt96Column(id)) {
Review Comment:
I'm a bit sceptical about having this check here. Can you elaborate why this
is the right place to perform the check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
