aokolnychyi commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1382326565


##########
api/src/main/java/org/apache/iceberg/ContentFile.java:
##########
@@ -165,6 +166,21 @@ default Long fileSequenceNumber() {
    */
   F copyWithoutStats();
 
+  /**
+   * Copies this file with only specific column stats. Manifest readers can 
reuse file instances;
+   * use this method to copy data and only copy specific stats when collecting 
files.
+   *
+   * @param columnsToKeepStats the set of the column ids for the columns which 
stats are kept. If
+   *     the columnsToKeepStats set is empty or <code>null</code>, then all 
column stats will be
+   *     kept.
+   * @return a copy of this data file, with stats lower bounds, upper bounds, 
value counts, null
+   *     value counts, and nan value counts for only specific columns.
+   */
+  default F copyWithStats(Set<Integer> columnsToKeepStats) {

Review Comment:
   If we decide to do 
[this](https://github.com/apache/iceberg/pull/8803#discussion_r1375314743) 
rename, we should probably be consistent here as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to