dimas-b commented on code in PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#discussion_r1378254490
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieUtil.java:
##########
@@ -165,4 +180,77 @@ public static TableMetadata
updateTableMetadataWithNessieSpecificProperties(
return builder.discardChanges().build();
}
+
+ static void handleExceptionsForCommits(
+ Exception exception, String refName, AtomicBoolean failure, Content.Type
type) {
+ if (exception instanceof NessieConflictException) {
+ failure.set(true);
Review Comment:
This looks awkward to me. Could this code be refactored somehow to avoid out
parameters? Maybe add a status class with multiple fields?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
