rdblue commented on code in PR #8659:
URL: https://github.com/apache/iceberg/pull/8659#discussion_r1367530281
##########
site/.github/bin/deploy_docs.sh:
##########
@@ -0,0 +1,57 @@
+#!/bin/bash
+
+while [[ "$#" -gt 0 ]]; do
+ case $1 in
+ -v|--version) ICEBERG_VERSION="$2"; shift ;;
+ *) echo "Unknown parameter passed: $1"; exit 1 ;;
+ esac
+ shift
+done
+
+GIT_BRANCH="docs-${ICEBERG_VERSION}"
+
+# change to branch
+git checkout -b $GIT_BRANCH
+
+cd ..
+
+# remove all files and directories minus exceptions
+find . \
+ -not \( -path . \) \
+ -not \( -path .. \) \
+ -not \( -path ./.git -prune \) \
Review Comment:
Ah, so this actually runs in the root of the iceberg repo itself?
That's a bit of a problem because we won't want to run it locally. I would
recommend updating this to not require deleting anything. Instead, I think this
should copy what you need into folders and add just those folders.
To me, the steps should be:
1. Copy the `nightly` docs folder into a temp folder
2. Build the docs in the temp folder
3. Copy the contents needed out of the temp site folder
4. Check out an orphan branch (with no parent) using `--orphan`
5. Add the site folder to git
6. Commit the site folder
7. Switch back to the previous tag
That way, everything in the working copy is handled by git rather than by
removing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
