amogh-jahagirdar commented on code in PR #8870:
URL: https://github.com/apache/iceberg/pull/8870#discussion_r1365470046


##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##########
@@ -281,6 +281,7 @@ protected String defaultWarehouseLocation(TableIdentifier 
tableIdentifier) {
                 .build());
     String dbLocationUri = response.database().locationUri();
     if (dbLocationUri != null) {
+      dbLocationUri = LocationUtil.stripTrailingSlash(dbLocationUri);

Review Comment:
   At first I was worried about the behavior change for callers of the API (now 
they cannot expect a trailing slash in case they were using the location in the 
response), but overall changing `loadNamespaceMetadata` makes sense. The API is 
pretty much used when updating namespace properties in which case stripping the 
trailing slash can serve as a correction mechanism for any future tables in the 
namespace. Existing tables in the namespace wouldn't see a change in behavior. 
Updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to