amogh-jahagirdar commented on PR #8870: URL: https://github.com/apache/iceberg/pull/8870#issuecomment-1770872534
> Just a wild guess, but could it be possible that we're missing to strip a trailing slash in > > https://github.com/apache/iceberg/blob/81bf8d30766b1b129b87abde15239645cb127046/core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java#L232 > ? That's another place I spotted as well, unfortunately while I think we should have stripped the trailing slash there to begin with, I don't think we can change that. The reason being, is if we change that the metadataFileLocation path for new metadata files would be different compared to the original location which would have double slash. This difference in where the metadata file gets written may confuse users and also have unintended side effects for external systems. Also I need to step through the code a bit more, but not sure if we always guaranteed at build/write time of the location that the trailing slash would be stripped. In that case we would already be covered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
