amogh-jahagirdar commented on code in PR #8860:
URL: https://github.com/apache/iceberg/pull/8860#discussion_r1362490912


##########
core/src/test/java/org/apache/iceberg/TableTestBase.java:
##########
@@ -110,7 +110,7 @@ public class TableTestBase {
   static final DataFile FILE_C =
       DataFiles.builder(SPEC)
           .withPath("/path/to/data-c.parquet")
-          .withFileSizeInBytes(10)
+          .withFileSizeInBytes(3_000_000L)

Review Comment:
   Err nvm, looks like split offsets for these files were added in #8834. 
Instead of changing the file size to fit the offsets (this breaks more tests 
that I need to go and update), I'll reverse it; I'll change the offsets to be 
within the file size since that was part of a more recent change and is 
isolated to a single test as far as I can tell.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to