advancedxy commented on PR #8834: URL: https://github.com/apache/iceberg/pull/8834#issuecomment-1763676271
Other than to revert the optimize in https://github.com/apache/iceberg/pull/8336, is it better to invalidate the cached `splitOffsetList`? The proposed change is in the `org.apache.iceberg.BaseFile#put` function: ```java ... case 12: this.upperBounds = SerializableByteBufferMap.wrap((Map<Integer, ByteBuffer>) value); return; case 13: this.keyMetadata = ByteBuffers.toByteArray((ByteBuffer) value); return; case 14: this.splitOffsets = ArrayUtil.toLongArray((List<Long>) value); this.splitOffsetList = null; // invalidate the cache return; case 15: this.equalityIds = ArrayUtil.toIntArray((List<Integer>) value); .... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
