Fokko commented on code in PR #8683:
URL: https://github.com/apache/iceberg/pull/8683#discussion_r1355723510


##########
format/spec.md:
##########
@@ -908,10 +919,12 @@ Lists must use the [3-level 
representation](https://github.com/apache/parquet-fo
 | **`float`**        | `float`                                                 
           |                                             |                      
                                          |
 | **`double`**       | `double`                                                
           |                                             |                      
                                          |
 | **`decimal(P,S)`** | `P <= 9`: `int32`,<br />`P <= 18`: `int64`,<br 
/>`fixed` otherwise | `DECIMAL(P,S)`                              | Fixed must 
use the minimum number of bytes that can store `P`. |
-| **`date`**         | `int32`                                                 
           | `DATE`                                      | Stores days from the 
1970-01-01.                               |
+| **`date`**         | `int32`                                                 
           | `DATE`                                      | Stores days from 
1970-01-01.                                   |

Review Comment:
   This change is fine to me 👍 



##########
format/spec.md:
##########
@@ -908,10 +919,12 @@ Lists must use the [3-level 
representation](https://github.com/apache/parquet-fo
 | **`float`**        | `float`                                                 
           |                                             |                      
                                          |
 | **`double`**       | `double`                                                
           |                                             |                      
                                          |
 | **`decimal(P,S)`** | `P <= 9`: `int32`,<br />`P <= 18`: `int64`,<br 
/>`fixed` otherwise | `DECIMAL(P,S)`                              | Fixed must 
use the minimum number of bytes that can store `P`. |
-| **`date`**         | `int32`                                                 
           | `DATE`                                      | Stores days from the 
1970-01-01.                               |
+| **`date`**         | `int32`                                                 
           | `DATE`                                      | Stores days from 
1970-01-01.                                   |

Review Comment:
   This change is fine to me 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to