rdblue commented on PR #8683: URL: https://github.com/apache/iceberg/pull/8683#issuecomment-1749792874
@jacobmarble, I was talking with @danielcweeks a couple days ago about v3 additions and we came up with a good reason to add `timestamp_ms` and `timestamptz_ms`. Currently, type promotion is limited to very specific changes, but we think that we will need to open that up in v3. As long as we are open to promoting types, it makes sense to let people promote `long` to `timestamp` of some kind. Now that we are adding timestamps with different units, this gives us a way to fix a long-standing problem: older data that used millisecond timestamps as longs couldn't be read as timestamps because we had no way to know the unit of the `long` (millis or micros). Now that we have separate types, we can use the type to carry that information, so that you can promote a `long` to `timestamp_ms` or `timestamp` and we know how to interpret the value. What do you think? If you agree, then we should probably add `ms` types at the same time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
