nastra commented on code in PR #8763:
URL: https://github.com/apache/iceberg/pull/8763#discussion_r1354363759


##########
spark/v3.5/spark/src/jmh/java/org/apache/iceberg/spark/action/IcebergSortCompactionBenchmark.java:
##########
@@ -280,6 +280,7 @@ protected Configuration initHadoopConf() {
     return new Configuration();
   }
 
+  @SuppressWarnings("unchecked")

Review Comment:
   I'd prefer to fix the underlying issue here rather than just suppressing 
this.
   
   ```
   -    SparkSessionCatalog catalog;
   +    SparkSessionCatalog<?> catalog;
        try {
          catalog =
   -          (SparkSessionCatalog) Spark3Util.catalogAndIdentifier(spark(), 
"spark_catalog").catalog();
   +          (SparkSessionCatalog<?>) Spark3Util.catalogAndIdentifier(spark(), 
"spark_catalog").catalog();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to