dimas-b commented on code in PR #8763:
URL: https://github.com/apache/iceberg/pull/8763#discussion_r1352824568
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##########
@@ -477,7 +477,7 @@ public void commitTable(
Branch branch =
getApi()
.commitMultipleOperations()
- .operation(Operation.Put.of(key, newTable, expectedContent))
+ .operation(Operation.Put.of(key, newTable))
Review Comment:
This change LGTM, but it's a non-trivial change in the Nessie Catalog,
certainly not a simple "compiler warning" kind of change...
@nk1506 : Would you mind moving it into a separate PR for the sake of
clarity?
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##########
@@ -477,7 +477,7 @@ public void commitTable(
Branch branch =
getApi()
.commitMultipleOperations()
- .operation(Operation.Put.of(key, newTable, expectedContent))
Review Comment:
This change LGTM, but it's a non-trivial change in the Nessie Catalog,
certainly not a simple "compiler warning" kind of change... Would you mind
moving it into a separate PR for the sake of clarity?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
