nastra commented on code in PR #8707: URL: https://github.com/apache/iceberg/pull/8707#discussion_r1350451880
########## dell/src/test/java/org/apache/iceberg/dell/mock/ecs/EcsS3MockRule.java: ########## @@ -33,16 +33,16 @@ import org.apache.iceberg.dell.DellClientFactories; import org.apache.iceberg.dell.DellProperties; import org.apache.iceberg.dell.mock.MockDellClientFactory; -import org.junit.rules.TestRule; -import org.junit.runner.Description; -import org.junit.runners.model.Statement; +import org.junit.jupiter.api.extension.AfterEachCallback; +import org.junit.jupiter.api.extension.BeforeEachCallback; +import org.junit.jupiter.api.extension.ExtensionContext; /** * Mock rule of ECS S3 mock. Review Comment: as part of this PR I think what makes sense is to change the javadoc here from `Mock rule of ECS S3 mock` to `Test extension for using an ECS S3 mock` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
