ashutosh-roy commented on code in PR #8707: URL: https://github.com/apache/iceberg/pull/8707#discussion_r1350435267
########## dell/src/test/java/org/apache/iceberg/dell/mock/ecs/EcsS3MockRule.java: ########## @@ -33,16 +33,16 @@ import org.apache.iceberg.dell.DellClientFactories; import org.apache.iceberg.dell.DellProperties; import org.apache.iceberg.dell.mock.MockDellClientFactory; -import org.junit.rules.TestRule; -import org.junit.runner.Description; -import org.junit.runners.model.Statement; +import org.junit.jupiter.api.extension.AfterEachCallback; +import org.junit.jupiter.api.extension.BeforeEachCallback; +import org.junit.jupiter.api.extension.ExtensionContext; /** * Mock rule of ECS S3 mock. Review Comment: I am thinking of adding these annotations in [this section ?](https://github.com/apache/iceberg/blob/master/CONTRIBUTING.md#junit4--junit5) Does that help or there's some other place I need to update in? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
