Fokko commented on code in PR #8672: URL: https://github.com/apache/iceberg/pull/8672#discussion_r1339942592
########## format/spec.md: ########## @@ -128,13 +128,13 @@ Tables do not require rename, except for tables that use atomic rename to implem #### Writer requirements -Some tables in this spec have columns that specify requirements for v1 and v2 tables. These requirements are intended for writers when adding metadata files to a table with the given version. +Some tables in this spec have columns that specify requirements for v1 and v2 tables. These requirements are intended for writers when adding metadata/manifest files to a table with the given version. Review Comment: > I thought previously metadata word is used as a generic word for all Iceberg metadata files not table metadata here. I agree with you here, I tried to be more explicit to avoid confusion between the metadata as a concept and the metadata file. Adding manifest-list is a good idea 👍 Let's take the suggestion (https://github.com/apache/iceberg/pull/8672#discussion_r1339897353) below. ########## format/spec.md: ########## @@ -128,13 +128,13 @@ Tables do not require rename, except for tables that use atomic rename to implem #### Writer requirements -Some tables in this spec have columns that specify requirements for v1 and v2 tables. These requirements are intended for writers when adding metadata files to a table with the given version. +Some tables in this spec have columns that specify requirements for v1 and v2 tables. These requirements are intended for writers when adding metadata/manifest files to a table with the given version. Review Comment: > I thought previously metadata word is used as a generic word for all Iceberg metadata files not table metadata here. I agree with you here, I tried to be more explicit to avoid confusion between the metadata as a concept and the metadata file. Adding manifest-list is a good idea 👍 Let's take the suggestion (https://github.com/apache/iceberg/pull/8672#discussion_r1339897353) below. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
