rdblue commented on code in PR #8446:
URL: https://github.com/apache/iceberg/pull/8446#discussion_r1330749373
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkFilters.java:
##########
@@ -161,10 +162,13 @@ public static Expression convert(Filter filter) {
case IN:
In inFilter = (In) filter;
+ if (Stream.of(inFilter.values()).anyMatch(Objects::isNull)) {
Review Comment:
Ah, I missed that we have specific handling to ensure that there is no IN
nested within NOT. I think you're right that this is okay after all. We should
probably double check more cases, like that the handling for `NOT(IN(1, 2))` is
also correct for `NOT(IN(1, 2, null)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
