aokolnychyi commented on code in PR #8446:
URL: https://github.com/apache/iceberg/pull/8446#discussion_r1330604555
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/sql/TestFilterPushDown.java:
##########
@@ -99,8 +99,14 @@ public void testFilterPushdownWithIdentityTransform() {
ImmutableList.of(row(3, 300, "d3")));
checkOnlyIcebergFilters(
+ "dep IN ('d1', 'd2')" /* query predicate */,
+ "dep IN ('d1', 'd2')" /* Iceberg scan filters */,
+ ImmutableList.of(row(1, 100, "d1"), row(2, 200, "d2")));
+
+ checkFilters(
"dep IN (null, 'd1')" /* query predicate */,
- "dep IN ('d1')" /* Iceberg scan filters */,
+ "dep IN (null,d1)" /* Spark post scan filter */,
+ "" /* Iceberg scan filters */,
Review Comment:
This does not seem right. Why can't we push a predicate like this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
