dimas-b commented on code in PR #8382:
URL: https://github.com/apache/iceberg/pull/8382#discussion_r1324792553
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieUtil.java:
##########
@@ -102,6 +102,38 @@ private static String commitAuthor(Map<String, String>
catalogOptions) {
.orElseGet(() -> System.getProperty("user.name"));
}
+ private static void checkAndUpdateGCProperties(
+ TableMetadata tableMetadata, Map<String, String> updatedProperties,
String identifier) {
+ if (tableMetadata.propertyAsBoolean(
Review Comment:
I think "table default" values from the catalog are enough. They will be set
in new tables by Iceberg core.
Edit: This is validated by
https://github.com/dimas-b/iceberg/blob/65ff515e061c1d339687c73d0c0202e04695a168/nessie/src/test/java/org/apache/iceberg/nessie/TestNessieTable.java#L579-L582
Old tables have the forced `false` values from the older version of this
this class anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
