snazy commented on code in PR #8382:
URL: https://github.com/apache/iceberg/pull/8382#discussion_r1324787576
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieUtil.java:
##########
@@ -102,6 +102,38 @@ private static String commitAuthor(Map<String, String>
catalogOptions) {
.orElseGet(() -> System.getProperty("user.name"));
}
+ private static void checkAndUpdateGCProperties(
+ TableMetadata tableMetadata, Map<String, String> updatedProperties,
String identifier) {
+ if (tableMetadata.propertyAsBoolean(
Review Comment:
Just thinking: should we add the lines
```java
updatedProperties.putIfAbsent(TableProperties.GC_ENABLED, "false");
updatedProperties.putIfAbsent(TableProperties.METADATA_DELETE_AFTER_COMMIT_ENABLED,
"false");
```
here at the beginning of the function, to ensure these values do always
default to `false` for Nessie?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
