bryanck commented on code in PR #8555:
URL: https://github.com/apache/iceberg/pull/8555#discussion_r1324794094
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/sink/RowDataTaskWriterFactory.java:
##########
@@ -108,7 +130,10 @@ public RowDataTaskWriterFactory(
@Override
public void initialize(int taskId, int attemptId) {
this.outputFileFactory =
- OutputFileFactory.builderFor(table, taskId,
attemptId).format(format).build();
+ OutputFileFactory.builderFor(initTable, taskId, attemptId)
+ .format(format)
+ .ioSupplier(() -> tableSupplier.get().io())
Review Comment:
Using the current table's FileIO to perform file operations should be safe,
I think it's actually desirable. For example, if write properties on the table
are updated, those will be applied at runtime rather than requiring a restart
(only if table reload is explicitly enabled).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
