bryanck commented on code in PR #8555:
URL: https://github.com/apache/iceberg/pull/8555#discussion_r1324747538


##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/sink/ManifestOutputFileFactory.java:
##########
@@ -70,7 +65,10 @@ private String generatePath(long checkpointId) {
   }
 
   OutputFile create(long checkpointId) {
-    String flinkManifestDir = props.get(FLINK_MANIFEST_LOCATION);
+    Table table = tableSupplier.get();
+    TableOperations ops = ((HasTableOperations) table).operations();
+
+    String flinkManifestDir = table.properties().get(FLINK_MANIFEST_LOCATION);

Review Comment:
   One note, this will reset the property if the task restarts (same as before).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to