nastra commented on code in PR #8555:
URL: https://github.com/apache/iceberg/pull/8555#discussion_r1324497815
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergStreamWriter.java:
##########
@@ -376,7 +376,7 @@ private OneInputStreamOperatorTestHarness<RowData,
WriteResult> createIcebergStr
icebergTable, Maps.newHashMap(), new
org.apache.flink.configuration.Configuration());
IcebergStreamWriter<RowData> streamWriter =
- FlinkSink.createStreamWriter(icebergTable, flinkWriteConfig,
flinkRowType, null);
+ FlinkSink.createStreamWriter(icebergTable, null, flinkWriteConfig,
flinkRowType, null, 0);
Review Comment:
I was thinking whether it would make sense to always default to `0` rather
than having to pass it explicitly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
