pvary commented on code in PR #8555:
URL: https://github.com/apache/iceberg/pull/8555#discussion_r1323981398
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java:
##########
@@ -207,7 +217,7 @@ public void snapshotState(StateSnapshotContext context)
throws Exception {
long checkpointId = context.getCheckpointId();
LOG.info(
"Start to flush snapshot state to state backend, table: {},
checkpointId: {}",
- table,
+ tableSupplier.get(),
Review Comment:
I think it would be better to get the `table` once per commit, and keep
using that table during the given commit operation. Fetching the table every
time could cause concurrency issues/surprises which are hard to track/reproduce.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
