aokolnychyi commented on code in PR #8123:
URL: https://github.com/apache/iceberg/pull/8123#discussion_r1323381086
##########
core/src/main/java/org/apache/iceberg/ManifestGroup.java:
##########
@@ -222,6 +223,19 @@ public CloseableIterable<ManifestEntry<DataFile>>
entries() {
return CloseableIterable.concat(entries((manifest, entries) -> entries));
}
+ /**
+ * Returns an iterable for groups of data files in the set of manifests.
+ *
+ * <p>Files are not copied, it is the caller's responsibility to make
defensive copies if adding
+ * these files to a collection.
+ *
+ * @return an iterable of file groups
+ */
+ public Iterable<CloseableIterable<DataFile>> fileGroups() {
Review Comment:
I called it `fileGroups` because instead of combining entries from all
manifests into a single iterable, it returns an iterable of iterables where
each element represents content of one manifest. Let me know if that makes
sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
