aokolnychyi commented on code in PR #8466:
URL: https://github.com/apache/iceberg/pull/8466#discussion_r1321846891
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedReaderBuilder.java:
##########
@@ -83,15 +85,15 @@ public VectorizedReader<?> message(
int id = field.fieldId();
VectorizedReader<?> reader = readersById.get(id);
if (idToConstant.containsKey(id)) {
- reorderedFields.add(new
VectorizedArrowReader.ConstantVectorReader<>(idToConstant.get(id)));
+ reorderedFields.add(new ConstantVectorReader<>(field,
idToConstant.get(id)));
} else if (id == MetadataColumns.ROW_POSITION.fieldId()) {
if (setArrowValidityVector) {
reorderedFields.add(VectorizedArrowReader.positionsWithSetArrowValidityVector());
} else {
reorderedFields.add(VectorizedArrowReader.positions());
}
} else if (id == MetadataColumns.IS_DELETED.fieldId()) {
- reorderedFields.add(new VectorizedArrowReader.DeletedVectorReader());
+ reorderedFields.add(new DeletedVectorReader());
Review Comment:
I had to import `ConstantVectorReader` to stay on one line above and because
we usually prefer direct imports. I changed this line for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
