aokolnychyi commented on code in PR #8466:
URL: https://github.com/apache/iceberg/pull/8466#discussion_r1313646958
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/ColumnVectorBuilder.java:
##########
@@ -38,8 +39,10 @@ public ColumnVector build(VectorHolder holder, int numRows) {
if (holder instanceof VectorHolder.DeletedVectorHolder) {
return new DeletedColumnVector(Types.BooleanType.get(), isDeleted);
} else if (holder instanceof ConstantVectorHolder) {
- return new ConstantColumnVector(
- Types.IntegerType.get(), numRows, ((ConstantVectorHolder<?>)
holder).getConstant());
+ ConstantVectorHolder<?> constantHolder = (ConstantVectorHolder<?>)
holder;
+ Type icebergType = constantHolder.icebergType();
Review Comment:
There is another issue with the current solution: our null vectors don't
report a type. Unfortunately, we also don't have the field info here at this
point. I'll need to take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
