aokolnychyi commented on code in PR #8381:
URL: https://github.com/apache/iceberg/pull/8381#discussion_r1305948442
##########
spark/v3.4/spark-runtime/src/integration/java/org/apache/iceberg/spark/SmokeTest.java:
##########
@@ -117,11 +117,7 @@ public void testAlterTable() throws NoSuchTableException {
sql("ALTER TABLE %s DROP PARTITION FIELD shard", tableName);
table = getTable();
- Assert.assertEquals("Table should have 4 partition fields", 4,
table.spec().fields().size());
- // VoidTransform is package private so we can't reach it here, just
checking name
- Assert.assertTrue(
- "All transforms should be void",
- table.spec().fields().stream().allMatch(pf ->
pf.transform().toString().equals("void")));
+ Assert.assertTrue("Table should be unpartitioned",
table.spec().isUnpartitioned());
Review Comment:
Yeah, I've used the new assertion style whenever adding new checks or when
modifying classes that migrated. Here, I modify the existing check so I
followed the rest of the class. I was not sure it is worth to just switch a
single check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
