aokolnychyi commented on code in PR #8381:
URL: https://github.com/apache/iceberg/pull/8381#discussion_r1303610435
##########
spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAlterTablePartitionFields.java:
##########
@@ -301,17 +284,33 @@ public void testReplacePartition() {
sql("ALTER TABLE %s ADD PARTITION FIELD days(ts)", tableName);
table.refresh();
PartitionSpec expected =
-
PartitionSpec.builderFor(table.schema()).withSpecId(1).day("ts").build();
+ PartitionSpecParser.fromJson(
Review Comment:
I had to switch to JSON so that I can correctly validate field IDs used in
the spec, which is not accessible in a programatic way in this module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
