RussellSpitzer commented on code in PR #8334:
URL: https://github.com/apache/iceberg/pull/8334#discussion_r1303209581
##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -213,10 +206,17 @@ FileIO io(String location) {
}
}
}
+
+ Preconditions.checkState(
Review Comment:
This is fine, but we could also do the cast in the try above and catch the
class cast exception. I'm fine with either approach and think there are
benefits to both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
