RussellSpitzer commented on code in PR #8334:
URL: https://github.com/apache/iceberg/pull/8334#discussion_r1303202589
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -76,7 +77,11 @@
* will result in {@link org.apache.iceberg.exceptions.ValidationException}.
*/
public class S3FileIO
- implements FileIO, SupportsBulkOperations, SupportsPrefixOperations,
CredentialSupplier {
+ implements FileIO,
+ SupportsBulkOperations,
Review Comment:
These are duplicate now right?
##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -31,18 +31,23 @@
import org.apache.iceberg.hadoop.SerializableConfiguration;
import
org.apache.iceberg.relocated.com.google.common.annotations.VisibleForTesting;
import org.apache.iceberg.relocated.com.google.common.base.Joiner;
+import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
import org.apache.iceberg.relocated.com.google.common.collect.Iterators;
import org.apache.iceberg.relocated.com.google.common.collect.Lists;
import org.apache.iceberg.relocated.com.google.common.collect.Maps;
import org.apache.iceberg.util.SerializableMap;
import org.apache.iceberg.util.SerializableSupplier;
-import org.apache.iceberg.util.Tasks;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-/** FileIO implementation that uses location scheme to choose the correct
FileIO implementation. */
-public class ResolvingFileIO implements FileIO, HadoopConfigurable,
SupportsBulkOperations {
+/**
+ * FileIO implementation that uses location scheme to choose the correct
FileIO implementation.
+ * Delegate FileIO implementations must implement the {@link DelegateFileIO}
mixin interface,
+ * otherwise initialization will fail.
+ */
+public class ResolvingFileIO
+ implements FileIO, HadoopConfigurable, SupportsBulkOperations,
SupportsPrefixOperations {
Review Comment:
could just implement DelgateFileIO itself here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
