rdblue commented on code in PR #8174:
URL: https://github.com/apache/iceberg/pull/8174#discussion_r1301887403
##########
python/pyiceberg/table/__init__.py:
##########
@@ -128,6 +144,25 @@ def _append_updates(self, *new_updates: TableUpdate) ->
Transaction:
self._updates = self._updates + new_updates
return self
+ def _append_requirements(self, *new_requirements: TableRequirement) ->
Transaction:
+ """Appends requirements to the set of staged requirements.
+
+ Args:
+ *new_requirements: Any new requirements.
+
+ Raises:
+ ValueError: When the type of requirement is not unique.
+
+ Returns:
+ Transaction object with the new requirements appended.
+ """
+ for requirement in new_requirements:
+ type_new_requirement = type(requirement)
+ if any(type(update) == type_new_requirement for update in
self._updates):
Review Comment:
Should this be `_updates` or `_requirements`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
