rdblue commented on code in PR #8174:
URL: https://github.com/apache/iceberg/pull/8174#discussion_r1301882264
##########
python/pyiceberg/schema.py:
##########
@@ -890,6 +892,22 @@ def __init__(self) -> None:
self._field_names: List[str] = []
self._short_field_names: List[str] = []
+ def before_map_key(self, key: NestedField) -> None:
+ self.before_field(key)
Review Comment:
Isn't this the default implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
