hililiwei commented on code in PR #8195:
URL: https://github.com/apache/iceberg/pull/8195#discussion_r1283145459
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/IcebergTableSink.java:
##########
@@ -71,7 +72,10 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context
context) {
"Unbounded data stream doesn't support overwrite operation.");
List<String> equalityColumns =
-
tableSchema.getPrimaryKey().map(UniqueConstraint::getColumns).orElseGet(ImmutableList::of);
+ tableSchema
+ .getPrimaryKey()
+ .map(UniqueConstraint::getColumns)
+ .orElseGet(() -> getEqualityColumnsFromProps(writeProps));
Review Comment:
We don't parse options this way.
You should refer to FlinkWriteOptions. Put`equlality columns` in
`writeOptions`( `FlinkSink.Builder#equalityFieldColumns`) like we did in
`FlinkSink.Builder#upsert`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
