hililiwei commented on code in PR #8174:
URL: https://github.com/apache/iceberg/pull/8174#discussion_r1282868032
##########
python/pyiceberg/table/__init__.py:
##########
@@ -152,6 +154,27 @@ def set_properties(self, **updates: str) -> Transaction:
"""
return self._append_updates(SetPropertiesUpdate(updates=updates))
+ def add_column(
Review Comment:
I have made changes and currently support both of the above usage.
But do we need to support the following way?
```
txn = table.transaction()
txn.update_schema().add_column(name="x", type_var=IntegerType(), doc="doc")
txn.commit_transaction()
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
