hililiwei commented on code in PR #8174:
URL: https://github.com/apache/iceberg/pull/8174#discussion_r1282861666
##########
python/pyiceberg/schema.py:
##########
@@ -1367,3 +1382,258 @@ def _(file_type: DecimalType, read_type: IcebergType)
-> IcebergType:
raise ResolveError(f"Cannot reduce precision from {file_type} to
{read_type}")
else:
raise ResolveError(f"Cannot promote an decimal to {read_type}")
+
+
+class UpdateSchema(ABC):
Review Comment:
> Do we need this ABC? Feels a bit Java'ish
I dropped that `ABC`. Does keeping `ABC` make it clearer that it is an
interface?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
