rdblue commented on code in PR #8123:
URL: https://github.com/apache/iceberg/pull/8123#discussion_r1275512380


##########
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##########
@@ -411,10 +439,14 @@ Builder scanMetrics(ScanMetrics newScanMetrics) {
       return this;
     }
 
-    DeleteFileIndex build() {
+    private Collection<DeleteFile> planFiles() {
+      if (deleteFiles != null) {
+        return deleteFiles;

Review Comment:
   Should this apply the `minSequenceNumber` filter? Seems like that would be 
more consistent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to