RussellSpitzer commented on code in PR #8123:
URL: https://github.com/apache/iceberg/pull/8123#discussion_r1275505036
##########
core/src/main/java/org/apache/iceberg/DataTableScan.java:
##########
@@ -52,12 +51,8 @@ public TableScan appendsAfter(long fromSnapshotId) {
}
@Override
- public TableScan useSnapshot(long scanSnapshotId) {
- // call method in superclass just for the side effect of argument
validation;
- // we do not use its return value
- super.useSnapshot(scanSnapshotId);
- Schema snapshotSchema = SnapshotUtil.schemaFor(table(), scanSnapshotId);
- return newRefinedScan(table(), snapshotSchema,
context().useSnapshotId(scanSnapshotId));
+ protected boolean useSnapshotSchema() {
+ return true;
Review Comment:
big difference from the previous implementation here? I assume i'll see
later that you moved the validation out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
