nastra commented on code in PR #8001:
URL: https://github.com/apache/iceberg/pull/8001#discussion_r1274539316
##########
.palantir/revapi.yml:
##########
@@ -774,6 +774,15 @@ acceptedBreaks:
- code: "java.method.removed"
old: "method org.apache.iceberg.view.ViewBuilder
org.apache.iceberg.view.ViewBuilder::withQueryColumnNames(java.util.List<java.lang.String>)"
justification: "Acceptable break due to updating View APIs and the View
Spec"
+ org.apache.iceberg:iceberg-core:
Review Comment:
we typically don't want to break the API without first going through a
deprecation cycle as indicated in
https://iceberg.apache.org/contribute/#minor-version-deprecations-required.
That being said, if we really want to rename this method, we would have to keep
`commitOrClean()` and mark it as deprecated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
